Review main Merged

51628[BUGFIX] Prevent exception when using link wizard in flexform input

Marcus Schwemer CR +2 V +2 Easy +1 −1 updated 02/12/17, 18:26

Commit message

The itemValue of a field might be null, which is not accepted
by getLinkExplanation(). Add a check to ensure we always pass a string.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Dominique Kreemers +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Dominique Kreemers +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1522

  1. Marcus Schwemer uploaded patch set 1 02/10/17, 16:00

  2. Marcus Schwemer updated the commit message in patch set 2 02/10/17, 16:01

  3. TYPO3com voted on patch set 1 V +1 02/10/17, 16:07 Completed build in 06m 19s on Fri, 10 Feb, 05:07 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7906

  4. Markus Klein commented on patch set 2 CR -1 02/10/17, 16:07

    This is the bug description => should be in forge the commit message must describe what is adjusted.

    InputLinkElement.php:303

    I would prefer to add a check to the calling function to avoid calling the function if there is no itemValue
  5. TYPO3com voted on patch set 2 V +1 02/10/17, 16:07 Completed build in 05m 44s on Fri, 10 Feb, 05:07 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7907

  6. Marcus Schwemer updated the commit message in patch set 3 02/10/17, 16:20

  7. Marcus Schwemer uploaded patch set 4 02/10/17, 16:21

  8. TYPO3com voted on patch set 3 V +1 02/10/17, 16:25 Completed build in 05m 34s on Fri, 10 Feb, 05:25 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7908

  9. TYPO3com voted on patch set 4 V +1 02/10/17, 16:28 Completed build in 06m 29s on Fri, 10 Feb, 05:28 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7909

  10. Marcus Schwemer uploaded patch set 5 02/11/17, 13:56

  11. Marcus Schwemer commented on patch set 5 02/11/17, 14:00

    Uploaded a new patchset, which contains also my first proposed solution. Until now the function is only used at one place, but we don't now about future use (also not very likely). If a second usage occurs, we also prevent the error there.
  12. TYPO3com voted on patch set 5 V +1 02/11/17, 14:01 Completed build in 04m 26s on Sat, 11 Feb, 03:01 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7928

  13. Markus Klein uploaded patch set 6 02/11/17, 18:23

  14. Markus Klein updated the commit message in patch set 7 02/11/17, 18:25

  15. Markus Klein voted on patch set 7 CR +1 02/11/17, 18:26

  16. TYPO3com voted on patch set 6 V +1 02/11/17, 18:31 Completed build in 08m 29s on Sat, 11 Feb, 07:31 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7935

  17. TYPO3com voted on patch set 7 V +1 02/11/17, 18:33 Completed build in 08m 10s on Sat, 11 Feb, 07:33 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7937

  18. Josef Glatz voted on patch set 7 CR +1 02/11/17, 19:24

  19. Josef Glatz voted on patch set 7 V +1 02/11/17, 19:24

  20. Dominique Kreemers voted on patch set 7 CR +1 V +1 02/12/17, 16:17

  21. Georg Ringer voted on patch set 7 CR +2 V +2 02/12/17, 18:26

  22. Gerrit merged patch set 7 02/12/17, 18:26