Review main Merged

51635[BUGFIX] Only set a session anonymous if in FE context

Nicole Hummel CR +2 V +2 Easy +7 −4 updated 02/11/17, 18:26

Commit message

The session id regeneration must not touch the sys_anonymous field
of the session record, since it only exists for FE session.
The FrontendUserAuthentication is responsible for this.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Nicole Hummel uploaded patch set 1 02/11/17, 15:24

  2. TYPO3com voted on patch set 1 V +1 02/11/17, 15:30 Completed build in 05m 21s on Sat, 11 Feb, 04:30 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7929

  3. Christian Kuhn commented on patch set 1 CR -1 02/11/17, 15:33

    i think that shouldn't be needed. only the FE supports this anonymuous sub-feature. i think markus should have a look at this.
  4. Nicole Hummel commented on patch set 1 02/11/17, 15:46

    Therefor I added Markus as well, tried to contacted him on Slack and commented the session patch.
  5. Markus Klein commented on patch set 1 CR -1 02/11/17, 17:55

    Investigation is correct, I'll adjust the patch to properly distinguish between FE/BE
  6. Markus Klein uploaded patch set 2 02/11/17, 18:08

  7. Markus Klein uploaded patch set 3 02/11/17, 18:12

  8. TYPO3com voted on patch set 2 V +1 02/11/17, 18:14 Completed build in 05m 46s on Sat, 11 Feb, 07:14 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7933

  9. Nicole Hummel commented on patch set 3 CR +1 V +1 02/11/17, 18:15

    Works. Thanks
  10. TYPO3com voted on patch set 3 V +1 02/11/17, 18:17 Completed build in 04m 50s on Sat, 11 Feb, 07:17 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7934

  11. Christian Kuhn voted on patch set 3 CR +1 02/11/17, 18:24

  12. Markus Klein voted on patch set 3 CR +2 V +2 02/11/17, 18:25

  13. Gerrit merged patch set 3 02/11/17, 18:26