Review main Merged

51642[BUGFIX] Eliminate gremlins in image cropper

Helmut Hummel CR +2 V +2 Hard +577 −193 updated 03/02/17, 20:02

Commit message

Refactor rendering to use two templates, a layout
and a partial to be more flexible.

Now also force the crop to be applied, even when
the editor does not open the image manipulation.

This is important when only one aspect ratio is
allowed to not allow the editor to save an invalid
state.

Eliminate several quirks in the TypeScript code,
among them:

* reset state when closing the cropper
* reset state when modal is dismissed
* correctly initialize all previews
* show correct size of crop area for big images
* avoid accidental dismiss of the modal

Last but not least add the accidentally removed form engine
wizard html fields again.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 4

Files 14