Review main Merged

51721[BUGFIX] Fix SQL error for single table view in list module

Frank Nägler CR +2 V +2 Easy +6 −6 updated 02/16/17, 23:17

Commit message

This patch fixes wrong field escaping due to simple implode of fields
in case label_alt is set for select or groups fields.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2
    • Jigal van Hemert +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Frank Nägler uploaded patch set 1 02/16/17, 17:01

  2. Anja Leichsenring updated the commit message in patch set 2 02/16/17, 17:03

  3. TYPO3com voted on patch set 1 V +1 02/16/17, 17:10 Completed build in 08m 05s on Thu, 16 Feb, 06:09 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8158

  4. TYPO3com voted on patch set 2 V +1 02/16/17, 17:12 Completed build in 08m 59s on Thu, 16 Feb, 06:12 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8160

  5. Oliver Hader voted on patch set 2 CR +1 02/16/17, 17:29

  6. Wouter Wolters voted on patch set 2 CR +1 02/16/17, 21:01

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 02/16/17, 22:51

  8. Jigal van Hemert voted on patch set 2 CR +2 V +2 02/16/17, 23:17

  9. Gerrit merged patch set 2 02/16/17, 23:17