Review main Merged

51757[BUGFIX] L10nModeUpdater: Cast parentId to integer

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 02/20/17, 08:00

Commit message

To prevent PHP errors in L10nModeUpdater caused by faulty extensions
whose `transOrigPointerField` field is not an integer, the parentId is
now always cast to an int.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Andreas Kienast uploaded patch set 1 02/19/17, 18:09

  2. TYPO3com voted on patch set 1 V +1 02/19/17, 18:16 Completed build in 07m 17s on Sun, 19 Feb, 07:16 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8269

  3. Thomas Hohn voted on patch set 1 CR +1 02/19/17, 19:48

  4. Josef Glatz voted on patch set 1 CR +1 02/19/17, 20:25

  5. Sascha Egerer commented on patch set 1 02/19/17, 20:47

    L10nModeUpdater.php:318

    Do we really need that $parentId variable? Is not used anywhere but below
  6. Markus Klein commented on patch set 1 02/19/17, 23:29

    cast is an irregular verb, hence "cast" is correct
  7. Markus Klein commented on patch set 1 02/19/17, 23:30

    L10nModeUpdater.php:318 Reply

    well it makes the thing a bit more readable
  8. Markus Klein updated the commit message in patch set 2 02/19/17, 23:31

  9. Markus Klein voted on patch set 2 CR +1 V +1 02/19/17, 23:31

  10. TYPO3com voted on patch set 2 V -1 02/19/17, 23:38 Completed build in 07m 13s on Mon, 20 Feb, 12:38 AM Test Summary: 1 of 56364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8286

  11. TYPO3com voted on patch set 2 V +1 02/20/17, 07:12 Completed build in 7h 49m 02s on Mon, 20 Feb, 08:12 AM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8286

  12. Georg Ringer voted on patch set 2 CR +2 V +2 02/20/17, 08:00

  13. Gerrit merged patch set 2 02/20/17, 08:00