Review main Merged

51759[BUGFIX] Add missing break statement in switch case

Sascha Egerer CR +2 V +2 Easy +5 −2 updated 02/20/17, 19:36

Commit message

There is a break statement missing in a switch case statement.
Currently this does not have any side effects but to prevent wrong
behavior in the future this should be fixed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Mona Muzaffar +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Sascha Egerer uploaded patch set 1 02/19/17, 19:45

  2. Thomas Hohn voted on patch set 1 CR +1 02/19/17, 19:47

  3. TYPO3com voted on patch set 1 V +1 02/19/17, 19:51 Completed build in 06m 19s on Sun, 19 Feb, 08:51 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8273

  4. Thomas Hohn commented on patch set 1 CR 0 02/19/17, 19:57

    TcaRecordTitle.php

    Isn't the @param/@return in one block?
  5. Josef Glatz updated the commit message in patch set 2 02/19/17, 20:20

  6. Josef Glatz commented on patch set 2 CR -1 02/19/17, 20:23

    Afaik, there should be no empty line between @params and @return. I think you're right @Thomas.
  7. TYPO3com voted on patch set 2 V +1 02/19/17, 20:28 Completed build in 07m 36s on Sun, 19 Feb, 09:28 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8274

  8. Sascha Egerer uploaded patch set 3 02/19/17, 20:43

  9. Sascha Egerer updated the commit message in patch set 4 02/19/17, 20:44

  10. TYPO3com voted on patch set 3 V +1 02/19/17, 20:50 Completed build in 07m 36s on Sun, 19 Feb, 09:50 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8279

  11. TYPO3com voted on patch set 4 V +1 02/19/17, 20:53 Completed build in 09m 33s on Sun, 19 Feb, 09:53 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8280

  12. Thomas Hohn commented on patch set 4 02/20/17, 06:44

    TcaRecordTitle.php:213

    Isn't there a missing '*' here?
  13. Andreas Kienast commented on patch set 4 02/20/17, 07:12

    TcaRecordTitle.php:213 Reply

    Nope, we do not have an empty line between @param and @return
  14. Mona Muzaffar voted on patch set 4 CR +1 02/20/17, 08:19

  15. Thomas Hohn commented on patch set 4 CR +1 02/20/17, 08:46

    TcaRecordTitle.php:213 Reply

    My bad - compared it to one of the previous versions where there suddenly was a lot of empty lines...
  16. Christian Kuhn voted on patch set 4 CR +2 V +2 02/20/17, 19:36

  17. Gerrit merged patch set 4 02/20/17, 19:36