Review main Merged

51772[BUGFIX] Install Tool configuration parser must handle nested config

Markus Klein CR +2 V +2 Hard +388 −207 updated 02/20/17, 18:05

Commit message

Since TYPO3_CONF_VARS may contain nested arrays and the array keys
for those subarrays may collide with first-level citizens (e.g. BE)
the current description parsing (parsing of PHP source code file)
fail hard for those cases.
The problem is not solvable without writing a dedicated full PHP parser
in order to have proper notion of nesting levels.
For this reason the regex-based parsing is completely removed and a
new and dedicated file for the option descriptions is introduced,
which stores the description into a PHP array.

This frees us from the buggy PHP code parsing with regex and enables us
in the future to enhance this array with more information.
(e.g. extract data type into a dedicated subarray element)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4