Review main Abandoned

51817[BUGFIX] Update comparison for datetime storage

Marc Neuhaus CR 0 V 0 Normal +108 −5 updated 11/03/21, 15:05

Commit message

Since the introduction of the new datetime storage format the comparisons
fail to work with non integer date columns, because the comparison
parameter was configured to be an integer. This commit checks, if the
column is a timestamp or datetime column and uses PDO::PARAM_STR for
datetime and PDO::PARAM_INT for timestamp columns. Additionally the
datamapper->getPlainValue methods needs the according columnMap in
order to convert any non UTC DateTimes into UTC, because datetime
columns need to be stored in UTC to prevent timezone problems, since
MySQL datetime columns can not store timezone information.
The Testbase->importXmlDatabaseFixture method was also changed
to apply the needed timezone conversion into UTC.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4