Review main Merged

51835[BUGFIX] Installtool blocked when session file is empty

Timo Hund CR +2 V +2 Easy +4 −1 updated 02/26/17, 20:42

Commit message

When the session information is fetched from the file system it can
happen that the session file is empty.

We should check for the file length and only read it, when the file
length is larger then 0.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Timo Hund uploaded patch set 1 02/24/17, 15:43

  2. Timo Hund commented on patch set 1 02/24/17, 15:47

    This is just a first version for a fix. I think it would also be interesting, why this file can be empty. One reason could be, that writing the file content(in SessionService::write) is interruped between ftruncate and fwrite. I don't know if we should check this in the scope of this issue?
  3. Georg Ringer commented on patch set 1 02/24/17, 15:49

    SessionService.php:393

    why not compare > 0?
  4. TYPO3com voted on patch set 1 V -1 02/24/17, 15:51 Completed build in 08m 07s on Fri, 24 Feb, 04:51 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8504

  5. Timo Hund uploaded patch set 2 02/24/17, 16:00

  6. TYPO3com voted on patch set 2 V -1 02/24/17, 16:08 Completed build in 08m 04s on Fri, 24 Feb, 05:08 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8505

  7. Thomas Hohn voted on patch set 2 CR +1 02/24/17, 17:24

  8. Thomas Hohn uploaded patch set 3 02/26/17, 19:06

  9. TYPO3com voted on patch set 3 V +1 02/26/17, 19:13 Completed build in 06m 34s on Sun, 26 Feb, 08:13 PM Test Summary: 56405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8633

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 02/26/17, 20:38

  11. Anja Leichsenring voted on patch set 3 CR +2 V +2 02/26/17, 20:42

  12. Gerrit merged patch set 3 02/26/17, 20:42