Review main Merged

51837[BUGFIX] Restore operability for USER displayConds

Claus Due CR +2 V +2 Easy +45 −4 updated 02/26/17, 22:28

Commit message

Parsing of the displayCond value was referencing the
incorrect array, causing the parsed displayCond to no
longer be correct. Referencing the correct array solves
the problem by generating the correct "named
condition array" based on the input.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Morton Jonuschat +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Claus Due uploaded patch set 1 02/24/17, 17:01

  2. TYPO3com voted on patch set 1 V +1 02/24/17, 17:12 Completed build in 11m 03s on Fri, 24 Feb, 06:12 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8509

  3. Joerg Kummer voted on patch set 1 CR +1 02/25/17, 17:54

  4. Christian Kuhn commented on patch set 1 CR -1 02/26/17, 17:21

    on it. let's see if we can have a unit test for this one.
  5. Christian Kuhn uploaded patch set 2 02/26/17, 17:39

  6. Christian Kuhn commented on patch set 2 CR +1 V +1 02/26/17, 17:40

    added a test that fails without patch and with patch.
  7. TYPO3com voted on patch set 2 V +1 02/26/17, 17:49 Completed build in 09m 56s on Sun, 26 Feb, 06:49 PM Test Summary: 56412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8619

  8. Wouter Wolters voted on patch set 2 CR +1 02/26/17, 22:13

  9. Morton Jonuschat voted on patch set 2 CR +2 V +2 02/26/17, 22:22

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 02/26/17, 22:27

  11. Gerrit merged patch set 2 02/26/17, 22:28