51902[BUGFIX] Add query restrictions for all tables in query
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Patrick Broens +1
- Morton Jonuschat +1
-
Verified V +2
- Georg Ringer +2
- Patrick Broens +1
- Morton Jonuschat +1
- TYPO3com +1 CI
Issues 1
Files 22
- typo3/sysext/core/Classes/Database/Query/Restriction/AbstractRestrictionContainer.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/BackendWorkspaceRestriction.php+5 −6
- typo3/sysext/core/Classes/Database/Query/Restriction/DeletedRestriction.php+3 −4
- typo3/sysext/core/Classes/Database/Query/Restriction/EndTimeRestriction.php+3 −3
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendGroupRestriction.php+3 −3
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php+2 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendWorkspaceRestriction.php+6 −7
- typo3/sysext/core/Classes/Database/Query/Restriction/HiddenRestriction.php+3 −4
- typo3/sysext/core/Classes/Database/Query/Restriction/RootLevelRestriction.php+4 −5
- typo3/sysext/core/Classes/Database/Query/Restriction/StartTimeRestriction.php+3 −4
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+5 −5
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/BackendWorkspaceRestrictionTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DefaultRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DeletedRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/EndTimeRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendGroupRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/HiddenRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/RootLevelRestrictionTest.php+5 −5
Review log 1216
-
Tymoteusz Motylewski uploaded patch set 1 02/28/17, 14:28
-
TYPO3com voted on patch set 1 V -1 02/28/17, 14:34 Completed build in 06m 28s on Tue, 28 Feb, 03:34 PM Test Summary: 157 of 56297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8751
-
Tymoteusz Motylewski uploaded patch set 2 02/28/17, 14:50
-
TYPO3com voted on patch set 2 V -1 02/28/17, 14:57 Completed build in 06m 19s on Tue, 28 Feb, 03:57 PM Test Summary: 48 of 56309 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8754
-
Tymoteusz Motylewski uploaded patch set 3 02/28/17, 15:08
-
TYPO3com voted on patch set 3 V +1 02/28/17, 15:14 Completed build in 06m 33s on Tue, 28 Feb, 04:14 PM Test Summary: 56309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8755
-
Tymoteusz Motylewski uploaded patch set 4 02/28/17, 15:51
-
TYPO3com voted on patch set 4 V +1 02/28/17, 15:59 Completed build in 07m 50s on Tue, 28 Feb, 04:59 PM Test Summary: 56315 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8758
-
Morton Jonuschat voted on patch set 4 CR +1 V +1 03/01/17, 07:52
-
Patrick Broens voted on patch set 4 CR +1 V +1 03/01/17, 08:11
-
Georg Ringer voted on patch set 4 CR +2 V +2 03/01/17, 08:26
-
Gerrit merged patch set 4 03/01/17, 08:26
-
Nicole Hummel commented on patch set 5 03/01/17, 10:47
Post -1: Due to this change it is now possible (again) do login in with an restricted (e.g. disabled) frontend user. I will care about an update ASAP. -
Nicole Hummel commented on patch set 5 03/01/17, 10:53
-
Nicole Hummel commented on patch set 5 03/01/17, 10:54
IMHO this is a breaking change of the doctrine api and needs a proper rst documentation. As now key and value is switched and with the old usage no TCA information is found anymore (see bugfix of user authentication). I would kindly ask you to add some rst file in the follow up) -
Tymoteusz Motylewski commented on patch set 5 03/01/17, 11:24
oh, damn, you're totally right Nicole. Thanks for spotting it and sorry for that.