51915[BUGFIX] Incorrect usages of string as array in QueryGenerator
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Thomas Hohn +1
- Markus Klein +1
-
Verified V +2
- Morton Jonuschat +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2027
Show 12 earlier messages
-
Christer V uploaded patch set 1 03/01/17, 11:48
-
TYPO3com voted on patch set 1 V +1 03/01/17, 11:54 Completed build in 06m 18s on Wed, 1 Mar, 12:54 PM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8799
-
Thomas Hohn voted on patch set 1 CR +1 03/01/17, 12:07
-
Georg Ringer updated the commit message in patch set 2 03/01/17, 21:34
-
Georg Ringer commented on patch set 2 CR +1 03/01/17, 21:34
7.6. should work with php 7.1 as well -
TYPO3com voted on patch set 2 V +1 03/01/17, 21:43 Completed build in 08m 58s on Wed, 1 Mar, 10:43 PM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8820
-
Markus Klein commented on patch set 2 CR -1 03/01/17, 21:48
This is a bug description and not a description of what has been changed.QueryGenerator.php:546The condition is not equal anymore. $queryConfig could be non-empty, but may not hold a type-field. This is not checked anymore. -
Christer V updated the commit message in patch set 3 03/02/17, 07:33
-
Christer V uploaded patch set 4 03/02/17, 07:34
-
TYPO3com voted on patch set 3 V +1 03/02/17, 07:42 Completed build in 09m 24s on Thu, 2 Mar, 08:42 AM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8826
-
TYPO3com voted on patch set 4 V +1 03/02/17, 07:44 Completed build in 10m 34s on Thu, 2 Mar, 08:44 AM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8827
-
Markus Klein commented on patch set 4 03/02/17, 08:57
anQueryGenerator.php:546this one is covered already by the second check. no need for that -
Markus Klein commented on patch set 5 03/02/17, 08:58
Published edit on patch set 4. -
Markus Klein commented on patch set 5 03/02/17, 08:59
QueryGenerator.php:546ah this must be !empty here to be the same as before -
Markus Klein commented on patch set 6 03/02/17, 08:59
Published edit on patch set 5. -
Markus Klein voted on patch set 6 CR +1 03/02/17, 09:00
-
Christer V commented on patch set 6 03/02/17, 09:09
QueryGenerator.php:546ReplyIs it even needed? We know $queryConfig is not an array. -
TYPO3com voted on patch set 5 V +1 03/02/17, 09:12 Completed build in 13m 02s on Thu, 2 Mar, 10:12 AM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8829
-
TYPO3com voted on patch set 6 V +1 03/02/17, 09:12 Completed build in 12m 26s on Thu, 2 Mar, 10:12 AM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8830
-
Christer V commented on patch set 6 CR -1 03/03/17, 07:16
QueryGenerator.php:546This should just be empty -
Christer V uploaded patch set 7 03/03/17, 07:22
-
TYPO3com voted on patch set 7 V +1 03/03/17, 07:30 Completed build in 07m 32s on Fri, 3 Mar, 08:30 AM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8848
-
Thomas Hohn voted on patch set 7 CR +1 03/03/17, 10:28
-
Markus Klein voted on patch set 7 CR +1 V +1 03/03/17, 12:08
-
Morton Jonuschat commented on patch set 7 03/04/17, 02:18
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit bb0d0315480560a23b3fd533b5f45eb8e20a7862 -
Morton Jonuschat voted on patch set 7 CR +2 V +2 03/04/17, 02:18
-
Gerrit merged patch set 7 03/04/17, 02:18