Review main Merged

51925[BUGFIX] Allows setting extended search per default

Dominik Winkelbauer CR +2 V +2 Easy +1 −1 updated 09/29/17, 11:23

Commit message

Makes it possible to enable extended search per default.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • Christian Futterlieb +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1722

  1. Dominik Winkelbauer uploaded patch set 1 03/02/17, 10:12

  2. Dominik Winkelbauer commented on patch set 2 03/02/17, 10:16

    Published edit on patch set 1.
  3. Dominik Winkelbauer wrote 03/02/17, 10:16

    Topic changed from Indexed Search: Allow setting extended search per default to 80091
  4. TYPO3com voted on patch set 2 V +1 03/02/17, 10:22 Completed build in 06m 29s on Thu, 2 Mar, 11:22 AM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8833

  5. Wouter Wolters updated the commit message in patch set 3 03/12/17, 21:30

  6. TYPO3com voted on patch set 3 V +1 03/12/17, 21:35 Completed build in 05m 24s on Sun, 12 Mar, 10:35 PM Test Summary: 56455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9098

  7. Jan Helke voted on patch set 3 CR +1 V +1 05/17/17, 16:34

  8. Wouter Wolters updated the commit message in patch set 4 05/18/17, 07:02

  9. TYPO3com voted on patch set 4 V +1 05/18/17, 07:09 Completed build in 06m 21s on Thu, 18 May, 09:09 AM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11557

  10. Frank Nägler commented on patch set 4 CR -1 05/19/17, 20:57

    SearchController.php:946

    I would prefer: if (!empty($searchData['extendedSearch'])) { to take care of a possible undefined index.
  11. Christian Futterlieb rebased onto patch set 5 09/12/17, 11:48

  12. Christian Futterlieb uploaded patch set 6 09/12/17, 11:50

  13. Christian Futterlieb commented on patch set 4 09/12/17, 11:51

    SearchController.php:946 Reply

    Done
  14. TYPO3com voted on patch set 5 V +1 09/12/17, 12:04 Completed build in 16m 09s on Tue, 12 Sep, 02:04 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14904

  15. Christian Futterlieb voted on patch set 6 CR +1 09/12/17, 12:05

  16. TYPO3com voted on patch set 6 V +1 09/12/17, 12:06 Completed build in 15m 47s on Tue, 12 Sep, 02:06 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14905

  17. Frank Nägler voted on patch set 6 CR +1 09/29/17, 10:57

  18. Christian Kuhn voted on patch set 6 CR +1 V +1 09/29/17, 11:22

  19. Frank Nägler voted on patch set 6 V +1 09/29/17, 11:22

  20. Frank Nägler voted on patch set 6 CR +2 V +2 09/29/17, 11:23

  21. Gerrit merged patch set 6 09/29/17, 11:23

  22. Frank Nägler commented on patch set 7 09/29/17, 11:23

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4df913de43e43cc40b34c0bd8de07dbc2456797e