Review main Merged

51928[BUGFIX] SchemaMigrator: Don't add indexes on changed columns

Thomas Hohn CR +2 V +2 Normal +57 −3 updated 03/04/17, 01:35

Commit message

Adding or changing an index on MySQL could sometimes fail due
to a dependency between the index definition and the column types.
On MySQL indexes on TEXT/BLOB types might require defining a
prefix length so that the index does not exceed storage limits.

Implement a check when migrating the database in a mode that
only adds fields and indexes such that added indexes do not touch
columns that require changes.

Also update the detection of required database changes in the
upgrade wizard so it does not get stuck on database changes
which will not be performed in that phase.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 4