51941[BUGFIX] Missing max value for title in file reference TCA
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Thomas Hohn +1
- Torben Hansen +1
-
Verified V +2
- Christian Kuhn +2
- Thomas Hohn +1
- Torben Hansen +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1720
-
Torben Hansen uploaded patch set 1 03/03/17, 18:36
-
TYPO3com voted on patch set 1 V +1 03/03/17, 18:46 Completed build in 09m 48s on Fri, 3 Mar, 07:46 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8872
-
Georg Ringer voted on patch set 1 CR +1 V +1 03/03/17, 19:03
-
Josef Glatz commented on patch set 1 CR -1 03/03/17, 19:26
-
Thomas Hohn commented on patch set 1 03/04/17, 00:29
sys_file_reference.php:205ReplyThe 1025 came with TYPO3 8 - FYI :-) -
Torben Hansen commented on patch set 1 03/04/17, 05:00
sys_file_reference.php:205ReplyThis is the field "Alternative Text", which is defined as tinytext. The field "Link" already has a max. of 1024. Or am I getting something wrong? -
Thomas Hohn commented on patch set 1 CR +1 03/04/17, 08:59
sys_file_reference.php:205ReplyMy bad - looked at the wrong column :-( -
Josef Glatz commented on patch set 1 CR +1 V +1 03/04/17, 09:06
Sorry Torben! I looked at the wrong line. -
Jörg Bösche voted on patch set 1 CR +1 V +1 03/13/17, 22:13
-
Gianluigi Martino voted on patch set 1 CR +1 V +1 03/14/17, 11:52
-
Christian Kuhn commented on patch set 1 CR -1 03/14/17, 21:29
the fun part ist: 'title' of sys_file_metadata is tinytext, 'title' of sys_file_reference is tinytext - ok, keep the max restriction. 'alternative' of sys_file_metadata is text, 'alternative' of sys_file_reference is tinytext -> wah? -> better increase 'alterantive' to text and not add the 'max' there, imho. furthermore, this patch is not for 6.2 anymore, which is in late security phase already. -
Christian Kuhn uploaded patch set 2 03/15/17, 07:58
-
Christian Kuhn updated the commit message in patch set 3 03/15/17, 08:00
-
Christian Kuhn voted on patch set 3 CR +1 V +1 03/15/17, 08:00
-
TYPO3com voted on patch set 2 V +1 03/15/17, 08:05 Completed build in 06m 56s on Wed, 15 Mar, 09:05 AM Test Summary: 56479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9172
-
TYPO3com voted on patch set 3 V +1 03/15/17, 08:08 Completed build in 08m 28s on Wed, 15 Mar, 09:08 AM Test Summary: 56479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9173
-
Torben Hansen voted on patch set 3 CR +1 V +1 03/15/17, 08:14
-
Thomas Hohn voted on patch set 3 CR +1 V +1 03/15/17, 08:34
-
Christian Kuhn voted on patch set 3 CR +2 V +2 03/15/17, 09:10
-
Gerrit merged patch set 3 03/15/17, 09:10
sys_file_reference.php:205