Review TYPO3_7-6 Merged

51944[BUGFIX] Incorrect usages of string as array in QueryGenerator

Morton Jonuschat CR +2 V +2 Easy +3 −1 updated 03/04/17, 19:03

Commit message

Changed so an empty $queryConfig is always an array.

$queryConfig is declared as an array but can be used as an array or
string, therefore in PHP 7.1 an exception was thrown.

Review

  • Code review CR +2
    • Morton Jonuschat +2
  • Verified V +2
    • Morton Jonuschat +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Morton Jonuschat commented on patch set 1 03/04/17, 02:18

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/04/17, 02:26 Completed build in 08m 30s on Sat, 4 Mar, 03:26 AM Test Summary: 38579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-794

  3. Morton Jonuschat voted on patch set 1 CR +2 V +2 03/04/17, 19:03

  4. Gerrit merged patch set 1 03/04/17, 19:03