Review main Merged

51953[BUGFIX] Replace class property caching with runtime cache

Claus Due CR +2 V +2 Normal +103 −81 updated 09/30/18, 12:08

Commit message

PageRepository is now used independantly from TSFE
most of the time, and a new instance is created each time a
content element gets rendered. This means that the current
cache strategy using class properties gets flushed repeatedly
and multiple identical SQL requests to be sent to the DB.

By replacing the class property caching with runtime cache
which survives across instances, the problem is solved.

On some sites this represents a reduction of several hundred
SQL requests.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1