Review main Abandoned

52066[TASK] Resort TcaOverrideChildCroppingConfiguration provider

Christian Kuhn CR 0 V 0 Easy +6 −9 updated 03/24/17, 22:35

Commit message

The FormEngine provider lists in DefaultConfiguration should be
executed top-bottom and should not be resorted much by the
DependencyResolver.
If that is not followed, the default list easily mutates to a pretty
hard to debug mess as soon as extensions declare additional providers
with 'before' and 'depends'. Therefore, the default lists always have
its direct predecessor as 'depends', which forces a straight top-bottom
flow. This is also why the default lists do not declare 'before'.
All further 'depends' are only cosmetical to declare codewise
dependencies in case anyone wants to move those data providers around
for whatever reason.
One provider violates this rule currently and is resorted in the
array a bit to follow the straight dependency line again.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1