52086[TASK] Remove l10n_cat leftover
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1315
-
Christian Kuhn uploaded patch set 1 03/17/17, 16:07
-
TYPO3com voted on patch set 1 V +1 03/17/17, 16:18 Completed build in 11m 18s on Fri, 17 Mar, 05:18 PM Test Summary: 56497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9287
-
Tymoteusz Motylewski commented on patch set 1 03/17/17, 18:27
isnt it used somehow by l10nmgr? -
Georg Ringer voted on patch set 1 CR +1 V +1 03/17/17, 18:49
-
Christian Kuhn commented on patch set 1 03/17/17, 19:00
yes, used in l10nmgr, but also only as some guad clause it seems. doesn't look as if it is of any important use, there. -
Wouter Wolters voted on patch set 1 CR +1 03/18/17, 14:54
-
Jo Hasenau commented on patch set 1 03/19/17, 08:36
L10nmgr uses this to "filter" data by l10n_categories, so actually this would have been quite useful to avoid things like "fieldname" of sys_file_references to be exported. But it has never been used correctly within the core and since this is a white list with a fallback to "everything" when not set, this should not be a breaking change for l10nmgr itself. The array containing the key currently is public though, so people building on top of l10nmgr might get problems. This is why I won't vote for or against it. -
Tymoteusz Motylewski commented on patch set 1 03/20/17, 08:17
@Jo, so the backwardcompatible solution would be to move l10n_cat to l10nmgr extension. In the way l10nmgr would enrich tca for core tables with this setting. -
Christian Kuhn commented on patch set 1 03/20/17, 09:59
ok, in this case i'd just keep the 'public localizationMode' in EditDocumentController, and mark it as deprecated (without throwing an deprecatation message here). this way it will survive v8 giving l10nmgr chances to adapt, and we can kick that with v9. -
Christian Kuhn uploaded patch set 2 03/20/17, 10:03
-
Georg Ringer voted on patch set 2 CR +1 V +1 03/20/17, 10:09
-
TYPO3com voted on patch set 2 V +1 03/20/17, 10:11 Completed build in 08m 22s on Mon, 20 Mar, 11:11 AM Test Summary: 56539 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9356
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 03/20/17, 10:16
-
Christian Kuhn voted on patch set 2 CR +2 V +2 03/20/17, 10:22
-
Gerrit merged patch set 2 03/20/17, 10:22