Review main Merged

52108[TASK] Clean up ['ctrl'] sortby and default_sortby

Christian Kuhn CR +2 V +2 Easy +9 −13 updated 03/22/17, 10:45

Commit message

sortby: An integer field with an explicit sorting value

default_sortby: A query->orderBy statement to sort records
if no explicit sortby field is given.

default_sortby is ignored if sortby is given. The patch removes
a couple of TCA ['ctrl']['default_sortby'] declarations where both
were defined.

default_sortby needs no "ORDER BY" prefix. The patch removes it
from those TCA tables where this prefix was still defined.

Additionally, the TCA reference docs have been improved in this
area to hint about both fields and their correlation. It is especially
evil if that is confused and a field like 'title' is set as sortby:
The DataHandler would happily write integers into that field on save.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13