Review main Merged

52178[BUGFIX] JS: Invert dependency definition for FormEngine and Validation

Markus Klein CR +2 V +2 Easy +20 −20 updated 03/27/17, 17:33

Commit message

FormEngineValidation is meant as integral part of FormEngine.
The current dependency definition is inverted, such that FormEngine
now depends on FormEngineValidation and not the other way around.
Note that FormEngineValidation does not need any other feature
of FormEngine, so this is safe.

This solves a possible race condition with other modules.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3