Review main Merged

52189[BUGFIX] Add TCA migration for columnsOverrides as well

Helmut Hummel CR +2 V +2 Hard +274 −26 updated 03/29/17, 19:20

Commit message

When migrating old TCA configuration to overrideChildTca,
we must respect columnsOverrides and do the migration there as well.

Also fix the examples for overriding cropVariants, which missed some
nesting levels

Review

  • Code review CR +2
    • Georg Ringer +2
    • Frans Saris +1
  • Verified V +2
    • Georg Ringer +2
    • Frans Saris +1

Issues 1

Files 3

Review log 1116

  1. Helmut Hummel uploaded patch set 1 03/27/17, 16:29

  2. Christian Kuhn commented on patch set 1 CR -1 03/27/17, 16:33

    TcaMigration.php:2434

    please do not split this into two methods: we're doing a series of migrations in both columnsOverrides and the columns field in various other methods above, too. and all of them do two loops with their dedicated messages that state the full patch within TCA - please keep that system. Should probably result in a merge of the two methods again.
  3. TYPO3com voted on patch set 1 V -1 03/27/17, 16:39 Completed build in 10m 27s on Mon, 27 Mar, 06:39 PM Test Summary: 56523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9664

  4. Helmut Hummel uploaded patch set 2 03/27/17, 16:47

  5. Helmut Hummel uploaded patch set 3 03/27/17, 16:56

  6. TYPO3com voted on patch set 2 V -1 03/27/17, 17:00 Completed build in 12m 29s on Mon, 27 Mar, 07:00 PM Test Summary: 56523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9668

  7. TYPO3com voted on patch set 3 V -1 03/27/17, 17:03 Completed build in 07m 15s on Mon, 27 Mar, 07:03 PM Test Summary: 1 of 56532 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9669

  8. Wouter Wolters voted on patch set 3 CR +1 03/27/17, 19:42

  9. Wouter Wolters rebased onto patch set 4 03/27/17, 20:04

  10. TYPO3com voted on patch set 4 V +1 03/27/17, 20:17 Completed build in 12m 30s on Mon, 27 Mar, 10:17 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9689

  11. Wouter Wolters voted on patch set 4 CR +1 V +1 03/27/17, 20:30

  12. Frans Saris uploaded patch set 5 03/29/17, 19:07

  13. Frans Saris voted on patch set 5 CR +1 V +1 03/29/17, 19:07

  14. Georg Ringer voted on patch set 5 CR +2 V +2 03/29/17, 19:18

  15. Gerrit merged patch set 5 03/29/17, 19:18

  16. TYPO3com commented on patch set 5 03/29/17, 19:20 Completed build in 12m 56s on Wed, 29 Mar, 09:20 PM Test Summary: 56531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9925