Review main Merged

52209[TASK] Deprecate AbstractFunctionModule->incLocalLang()

Benni Mack CR +2 V +2 Normal +48 −3 updated 03/28/17, 12:31

Commit message

Loading a locallang.xlf inside the abstract function module now uses the regular
$GLOBALS['LANG']->includeLLFile() of the current file, instead of doing a manual
check on .xml and .php extensions, which the LanguageService/LanguageFactory
is taking care of anyway.

The PHP method incLocalLang() and the now not necessarily needed $thisPath
are therefore marked as deprecated.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2