Review main Merged

52228[FEATURE] Improved JavaScript Modal API

Benjamin Kott CR +2 V +2 Expert +1045 −477 updated 03/31/17, 12:51

Commit message

To improve the usability and flexibility for a unified handling of
overlays in the backend we're opening the existing API for modals to be
more flexible and adjustable to your needs for advanced usage. With the
introduction of the advanded API it is now possible to pass configuration
via a json object. This enables more easy configuation and better
fallbacks if the modal is not correctly configured.

For a unified experience all modals are now centered by default, will be
kept in place automatically and are available in different sizes depending
on your needs. In addition to this there is also a new type for loading
content into an iframe. Buttons now have full support for the TYPO3 Icon
API and data attributes can also be set by configuration.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 17