Review main Merged

52282[TASK] Extract target attribute resolving from typolink

Benni Mack CR +2 V +2 Normal +35 −52 updated 03/31/17, 17:34

Commit message

The repetitive code for each typolink method is moved to
a separate method in order to allow the LinkService to do the main job.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Benni Mack uploaded patch set 1 03/31/17, 08:52

  2. TYPO3com voted on patch set 1 V -1 03/31/17, 09:02 Completed build in 10m 35s on Fri, 31 Mar, 11:02 AM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10026

  3. Mathias Brodala commented on patch set 1 03/31/17, 09:14

    ContentObjectRenderer.php:6041

    Maybe add :string as return type hint here?
  4. Benni Mack uploaded patch set 2 03/31/17, 10:30

  5. Benni Mack uploaded patch set 3 03/31/17, 10:31

  6. TYPO3com voted on patch set 2 V +1 03/31/17, 10:55 Completed build in 25m 28s on Fri, 31 Mar, 12:55 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10048

  7. TYPO3com voted on patch set 3 V +1 03/31/17, 10:59 Completed build in 27m 20s on Fri, 31 Mar, 12:59 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10050

  8. Frank Nägler voted on patch set 3 CR +1 03/31/17, 13:18

  9. Frank Nägler voted on patch set 3 V +1 03/31/17, 13:32

  10. Christian Kuhn commented on patch set 3 03/31/17, 14:45

    ContentObjectRenderer.php:6034

    empty line

    ContentObjectRenderer.php:6043

    due to the ?
  11. Christian Kuhn uploaded patch set 4 03/31/17, 14:50

  12. Christian Kuhn voted on patch set 4 CR +1 V +1 03/31/17, 14:51

  13. Frank Nägler voted on patch set 4 CR +1 V +1 03/31/17, 14:54

  14. TYPO3com voted on patch set 4 V +1 03/31/17, 15:00 Completed build in 09m 24s on Fri, 31 Mar, 05:00 PM Test Summary: 56554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10081

  15. Christian Kuhn voted on patch set 4 CR +2 V +2 03/31/17, 17:34

  16. Gerrit merged patch set 4 03/31/17, 17:34