Review main Merged

52294[BUGFIX] Enhance workspace handling of language synchronization

Oliver Hader CR +2 V +2 Normal +237 −8 updated 07/17/26, 11:26

Commit message

Workspace handling of synchronizing languages between ancestor and
dependent records has been missing. Basically this is all about
resolving the live UID of records that are used for l10n_parent
fields as well as for other relations pointers.

This happens in a very "basic" construct in every versioned
record for editor - even without relations:

When switching to a workspace, one edits an existing page (with
translations) and sets a field with "allowLanguageSynchronization".

FormEngine - in Workspace=1 - utilizes the liveId in data[pages][123]
obviously. When persisting, a new version is created and subsequent
edits use the versioned ID in FormEngine (input name="data[pages][124]")
which are thus not working anymore.

This patch solves the actual problem, making
"allowLanguageSynchronization" work fully now.

The main trick is to always resolve to the live version of the
default langauge (l10n_parent ID) over and over again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Lisa Kreitz +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Lisa Kreitz +1
    • core-ci +1 CI

Issues 4

Files 5

Review log 6399

Show 4474 earlier messages
  1. Oliver Hader uploaded patch set 1 03/31/17, 12:57

  2. TYPO3com voted on patch set 1 V -1 03/31/17, 13:11 Completed build in 14m 29s on Fri, 31 Mar, 03:11 PM Test Summary: 56590 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10063

  3. Oliver Hader uploaded patch set 2 03/31/17, 21:14

  4. Oliver Hader voted on patch set 2 CR -1 03/31/17, 21:14

  5. TYPO3com voted on patch set 2 V -1 03/31/17, 21:24 Completed build in 09m 32s on Fri, 31 Mar, 11:24 PM Test Summary: 8 of 56629 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10119

  6. Oliver Hader uploaded patch set 3 04/02/17, 19:05

  7. TYPO3com voted on patch set 3 V +1 04/02/17, 19:14 Completed build in 08m 23s on Sun, 2 Apr, 09:14 PM Test Summary: 56610 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10179

  8. Oliver Hader uploaded patch set 4 04/03/17, 17:21

  9. TYPO3com voted on patch set 4 V -1 04/03/17, 17:32 Completed build in 10m 29s on Mon, 3 Apr, 07:32 PM Test Summary: 12 of 56681 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10249

  10. Oliver Hader updated the commit message in patch set 5 04/03/17, 17:34

  11. TYPO3com voted on patch set 5 V -1 04/03/17, 17:46 Completed build in 11m 36s on Mon, 3 Apr, 07:46 PM Test Summary: 12 of 56681 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10251

  12. TYPO3com commented on patch set 5 04/03/17, 17:55 Completed build in 31m 43s on Mon, 3 Apr, 07:55 PM Test Summary: 12 of 56681 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10251

  13. Oliver Hader commented on patch set 5 CR -1 04/03/17, 18:02

    Strange... I cannot reproduce the bamboo failures on my local environment...
  14. Oliver Hader commented on patch set 5 04/03/17, 22:08

    Okay, Travis now show similar failures https://travis-ci.org/ohader/TYPO3.CMS/builds/218254473
  15. Oliver Hader uploaded patch set 6 04/03/17, 22:29

  16. TYPO3com voted on patch set 6 V +1 04/03/17, 22:38 Completed build in 08m 53s on Tue, 4 Apr, 12:38 AM Test Summary: 56680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10265

  17. Susi Moog commented on patch set 6 V -1 04/17/17, 09:47

    Scenario: - Create a new content element in workspace - Click on "translate" - Choose "translate" (not copy) Result: - Two content elements show up in translation: -- the translated element (looks like it should) -- and a second element --> PLACEHOLDER, WS#1 --> which is also editable.
  18. Susi Moog commented on patch set 6 04/17/17, 10:30

    Scenario: Live Workspace: - Content Element with IRRE relation -- IRRE child has field header with allowLanguageSynchronization = true - Translate (not copy) element - Switch to workspace - Edit translated element - change IRRE child header field to custom value - Save element Result: - Translation behavior changes back to "use parent" / value does not get saved.
  19. Susi Moog commented on patch set 6 04/17/17, 10:34

    Scenario: - In workspace, page existing on live - create new content element (with IRRE relation, header field "allowLanguageSynchronization") - Translate element - Edit translation, change IRRE child header to custom value, enter something - Click Save Result: - Translation behavior resets to "use parent" - BUT: value gets saved and shows up "non-editable"
  20. Oliver Hader voted on patch set 6 CR -1 04/17/17, 20:37

  21. Oliver Hader uploaded patch set 7 06/14/17, 15:09

  22. Oliver Hader commented on patch set 7 CR -1 06/14/17, 15:09

    Just rebased, there's more to do...
  23. TYPO3com voted on patch set 7 V -1 06/14/17, 15:24 Completed build in 15m 31s on Wed, 14 Jun, 05:24 PM Test Summary: 174 of 56664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12577

  24. Oliver Hader uploaded patch set 8 06/14/17, 17:10

  25. TYPO3com voted on patch set 8 V -1 06/14/17, 17:23 Completed build in 13m 05s on Wed, 14 Jun, 07:23 PM Test Summary: 3 of 56664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12584

  26. Oliver Hader uploaded patch set 9 06/16/17, 10:15

  27. TYPO3com voted on patch set 9 V +1 06/16/17, 10:29 Completed build in 14m 01s on Fri, 16 Jun, 12:29 PM Test Summary: 56661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12619

  28. Oliver Hader uploaded patch set 10 06/16/17, 12:15

  29. TYPO3com voted on patch set 10 V +1 06/16/17, 12:27 Completed build in 11m 57s on Fri, 16 Jun, 02:27 PM Test Summary: 56646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12627

  30. Oliver Hader uploaded patch set 11 06/16/17, 12:33

  31. TYPO3com voted on patch set 11 V -1 06/16/17, 12:56 Completed build in 22m 51s on Fri, 16 Jun, 02:56 PM Test Summary: 1 of 56661 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12628

  32. Oliver Hader uploaded patch set 12 06/16/17, 14:39

  33. TYPO3com voted on patch set 12 V -1 06/16/17, 14:51 Completed build in 11m 32s on Fri, 16 Jun, 04:51 PM Test Summary: 3 of 56670 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12629

  34. Oliver Hader uploaded patch set 13 06/16/17, 18:11

  35. TYPO3com voted on patch set 13 V -1 06/16/17, 18:23 Completed build in 12m 06s on Fri, 16 Jun, 08:23 PM Test Summary: 56667 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12636

  36. Oliver Hader uploaded patch set 14 06/16/17, 18:24

  37. Oliver Hader uploaded patch set 15 06/16/17, 18:34

  38. TYPO3com voted on patch set 14 V +1 06/16/17, 18:35 Completed build in 11m 08s on Fri, 16 Jun, 08:35 PM Test Summary: 56667 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12638

  39. TYPO3com voted on patch set 15 V -1 06/16/17, 18:43 Completed build in 09m 03s on Fri, 16 Jun, 08:43 PM Test Summary: 34 of 56670 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12639

  40. Oliver Hader uploaded patch set 16 06/16/17, 19:28

  41. TYPO3com voted on patch set 16 V -1 06/16/17, 19:39 Completed build in 10m 35s on Fri, 16 Jun, 09:39 PM Test Summary: 58 of 56670 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12640

  42. Oliver Hader uploaded patch set 17 06/16/17, 19:40

  43. TYPO3com voted on patch set 17 V -1 06/16/17, 19:51 Completed build in 10m 58s on Fri, 16 Jun, 09:51 PM Test Summary: 34 of 56670 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12641

  44. TYPO3com commented on patch set 17 06/16/17, 19:57 Completed build in 28m 07s on Fri, 16 Jun, 09:57 PM Test Summary: 34 of 56670 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12641

  45. Oliver Hader uploaded patch set 18 06/16/17, 19:57

  46. TYPO3com voted on patch set 18 V +1 06/16/17, 20:07 Completed build in 10m 05s on Fri, 16 Jun, 10:07 PM Test Summary: 56667 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12642

  47. Oliver Hader uploaded patch set 19 06/29/17, 15:13

  48. TYPO3com voted on patch set 19 V -1 06/29/17, 15:25 Completed build in 11m 43s on Thu, 29 Jun, 05:25 PM Test Summary: 18 of 57274 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12897

  49. Oliver Hader uploaded patch set 20 06/30/17, 15:06

  50. TYPO3com voted on patch set 20 V -1 06/30/17, 15:19 Completed build in 12m 06s on Fri, 30 Jun, 05:19 PM Test Summary: 54 of 57274 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12935

  51. TYPO3com commented on patch set 20 07/03/17, 05:28 Completed build in 14h 33m 36s on Mon, 3 Jul, 07:28 AM Test Summary: 54 of 57274 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12935

  52. Oliver Hader abandoned the change 10/19/17, 20:58

    Close due to lack of feedback
  53. Benni Mack restored the change 11/18/21, 11:44

  54. Benni Mack wrote 11/29/21, 10:19

    Change destination moved from master to main
  55. Benni Mack updated the commit message in patch set 21 11/29/21, 14:06

  56. Oliver Hader marked it work in progress 05/03/22, 11:37

  57. Benni Mack commented on patch set 21 07/29/25, 07:53

    DataHandler.php:6182

    means: we always use the live ID for l10n_parent

    DataMapProcessor.php:1074

    the incoming ID could be a new version, a classic edit in the version, a delete placeholder or a move placeholder
  58. Benni Mack uploaded patch set 22 08/12/25, 10:06

  59. Benni Mack commented on patch set 22 08/12/25, 10:07

    DataMapProcessor.php:796

    I don't think this is needed anymore

    DataMapProcessor.php:1074 Reply

    we need to evaluate if still need this code.
  60. core-ci voted on patch set 22 V +1 08/12/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83194

  61. Benni Mack uploaded patch set 23 V +1 08/13/25, 14:58

  62. core-ci voted on patch set 23 V +1 08/13/25, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83312

  63. Matthias Vogel uploaded patch set 24 V +1 10/31/25, 10:01

  64. core-ci voted on patch set 24 V -1 10/31/25, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88241

  65. Matthias Vogel rebased onto patch set 25 V -1 02/10/26, 12:57

  66. core-ci voted on patch set 25 V -1 02/10/26, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95543

  67. Oliver Hader commented on patch set 25 02/10/26, 15:04

    DataHandler.php:7034

    Could be extracted to separate method (or methods, plural)

    DataMapItem.php:419

    Move below `getSourceFieldName()`

    VersionToLiveIdMap.php:36

    So, it should probably be a runtime cache instead. As alternative, it might be a shared service (which would be dropped, when a new DI container is used - e.g. in test cases).
  68. Benni Mack uploaded patch set 26 V -1 02/14/26, 11:04

  69. core-ci voted on patch set 26 V +1 02/14/26, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95886

  70. Benni Mack commented on patch set 26 02/14/26, 11:22

    DataHandler.php:7034 Reply

    Done

    DataMapItem.php:419 Reply

    Done
  71. Benni Mack uploaded patch set 27 V +1 02/14/26, 13:45

  72. Benni Mack uploaded patch set 28 02/14/26, 14:03

  73. core-ci voted on patch set 28 V +1 02/14/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95895

  74. core-ci voted on patch set 27 V -1 02/14/26, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95893

  1. Benni Mack uploaded patch set 29 V +1 02/14/26, 15:06

  2. core-ci voted on patch set 29 V +1 02/14/26, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95906

  3. Benni Mack marked it ready for review 02/14/26, 20:36

  4. Benni Mack commented on patch set 29 02/16/26, 07:57

    DataMapProcessor.php:796 Reply

    Done

    DataMapProcessor.php:1074 Reply

    Done
  5. Benni Mack commented on patch set 29 02/16/26, 07:58

    DataHandler.php:6182 Reply

    Done
  6. Benni Mack uploaded patch set 30 V +1 03/04/26, 17:09

  7. core-ci voted on patch set 30 V +1 03/04/26, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97350

  8. Benni Mack updated the commit message in patch set 31 V +1 04/22/26, 06:42

  9. core-ci voted on patch set 31 V -1 04/22/26, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100767

  10. core-ci voted on patch set 31 V +1 05/03/26, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100767

  11. Oliver Klee voted on patch set 31 V +1 05/03/26, 08:39

  12. Benni Mack uploaded patch set 32 V +1 07/15/26, 13:31

  13. core-ci voted on patch set 32 V +1 07/15/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104796

  14. Benni Mack commented on patch set 32 07/15/26, 13:50

    This change is ready for review.

    VersionToLiveIdMap.php:36 Reply

    Done
  15. Markus Klein commented on patch set 32 07/15/26, 13:57

    @oliver.hader@typo3.org I think our change is closely related here https://review.typo3.org/c/Packages/TYPO3.CMS/+/94469
  16. Benni Mack commented on patch set 32 07/15/26, 14:54

    Reply

    Hey Markus, I took over the patch. This patch is now 8 years old (do a diff :)) and I hope to get it merged really really soon, if we finally get enough votes. It is now really really easy to reproduce https://forge.typo3.org/issues/107262 (see the steps), I want this for our v14 client. I am happy to look at your solution, but it seems like it's a similar solution to the same issue?
  17. Lisa Kreitz voted on patch set 32 CR +1 V +1 07/15/26, 15:00

  18. Markus Klein commented on patch set 32 07/16/26, 14:31

    Reply

    Sure, I'll take a closer look and yes, this should get fixed. Our fix evolved from v13 though, this patch does not cover v13... meh. ;-)
  19. Benni Mack updated the commit message in patch set 33 CR +1 V +1 07/16/26, 15:15

  20. core-ci voted on patch set 33 V +1 07/16/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104835

  21. Benni Mack voted on patch set 33 CR +1 V +1 07/16/26, 15:24

  22. Lisa Kreitz voted on patch set 33 CR +1 V +1 07/17/26, 11:03

  23. Markus Klein voted on patch set 33 CR +1 07/17/26, 11:24

  24. Benni Mack voted on patch set 33 CR +2 V +2 07/17/26, 11:25

  25. Benni Mack merged patch set 34 07/17/26, 11:26