Review main Merged

52344[BUGFIX] typolink: Ensure explode() is using string

Nicole Hummel CR +2 V +2 Normal +56 −1 updated 04/03/17, 22:22

Commit message

Link to home page with section and enabled realurl ends up in uncaught
exception because the new PageLinkBuilder is a PHP7 strict
class, and thus, throws errors when explode() is used with null
as parameter.

Review

  • Code review CR +2
    • Markus Klein +2
    • Claus Due +1
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1320

  1. Nicole Hummel uploaded patch set 1 04/03/17, 17:36

  2. Nicole Hummel updated the commit message in patch set 2 04/03/17, 17:38

  3. TYPO3com voted on patch set 2 V -1 04/03/17, 17:50 Completed build in 12m 10s on Mon, 3 Apr, 07:50 PM Test Summary: 2 of 56585 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10253

  4. TYPO3com voted on patch set 1 V -1 04/03/17, 17:51 Completed build in 14m 59s on Mon, 3 Apr, 07:51 PM Test Summary: 2 of 56585 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10252

  5. Benni Mack uploaded patch set 3 04/03/17, 21:30

  6. TYPO3com voted on patch set 3 V -1 04/03/17, 21:37 Completed build in 07m 16s on Mon, 3 Apr, 11:37 PM Test Summary: 2 of 56585 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10257

  7. Benni Mack commented on patch set 4 04/03/17, 21:39

    Published edit on patch set 3.
  8. Benni Mack updated the commit message in patch set 5 04/03/17, 21:41

  9. Nicole Hummel voted on patch set 5 CR +1 V +1 04/03/17, 21:46

  10. TYPO3com voted on patch set 4 V -1 04/03/17, 21:53 Completed build in 13m 25s on Mon, 3 Apr, 11:53 PM Test Summary: 2 of 56585 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10258

  11. Nicole Hummel uploaded patch set 6 04/03/17, 21:54

  12. TYPO3com voted on patch set 5 V -1 04/03/17, 21:59 Completed build in 18m 12s on Mon, 3 Apr, 11:59 PM Test Summary: 2 of 56585 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10259

  13. Nicole Hummel uploaded patch set 7 04/03/17, 22:01

  14. TYPO3com voted on patch set 6 V -1 04/03/17, 22:04 Completed build in 09m 38s on Tue, 4 Apr, 12:04 AM Test Summary: 2 of 56585 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10261

  15. Claus Due voted on patch set 7 CR +1 04/03/17, 22:06

  16. TYPO3com voted on patch set 7 V +1 04/03/17, 22:14 Completed build in 12m 52s on Tue, 4 Apr, 12:14 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10263

  17. Benni Mack voted on patch set 7 CR +1 V +1 04/03/17, 22:15

  18. Markus Klein commented on patch set 7 CR -1 04/03/17, 22:18

    reviewing
  19. Markus Klein voted on patch set 7 CR +2 V +2 04/03/17, 22:22

  20. Gerrit merged patch set 7 04/03/17, 22:22