Review main Merged

52351[BUGFIX] Creating typolink in backend should not throw an exception

Benni Mack CR +2 V +2 Easy +18 −0 updated 04/04/17, 08:01

Commit message

The global $TSFE object is not available in the Backend anymore.

In order to use <f:link.typolink> in e.g. a toolbar item or a preview
element, the TSFE object should be created as dummy so at least an index.php
URL (or external URL) is shown.

Review

  • Code review CR +2
    • Benni Mack +2
    • Frans Saris +1
    • Oliver Hader +1
  • Verified V +2
    • Benni Mack +2
    • Frans Saris +1
    • Mona Muzaffar +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1719

  1. Benni Mack uploaded patch set 1 04/04/17, 06:40

  2. TYPO3com voted on patch set 1 V +1 04/04/17, 06:48 Completed build in 07m 56s on Tue, 4 Apr, 08:48 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10271

  3. Thomas Hohn voted on patch set 1 CR +1 04/04/17, 06:50

  4. Susi Moog voted on patch set 1 CR +1 04/04/17, 06:54

  5. Frans Saris voted on patch set 1 CR +1 04/04/17, 06:55

  6. Susi Moog voted on patch set 1 V +1 04/04/17, 06:57

  7. Oliver Hader commented on patch set 1 CR +1 04/04/17, 07:32

    This might have side-effects concerning the injected ID via GetPost or cross-domain linking... for a basic URL generation it should be enough however
  8. Frans Saris commented on patch set 1 04/04/17, 07:38

    <f:link.typolink parameter="http://www.typo3.com">test</f:link.typolink>; goes ok, but <f:link.typolink parameter="3">test</f:link.typolink> gives me an exception not sure if the second is supported? Call to a member function linkData() on null Error thrown in file /var/www/master/typo3_src-git/typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php in line 194. 45 TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::build(array, "test", "", array)
  9. Mona Muzaffar voted on patch set 1 V +1 04/04/17, 07:42

  10. Benni Mack voted on patch set 1 CR +2 V +2 04/04/17, 07:45

  11. Benni Mack voted on patch set 1 CR -2 04/04/17, 07:46

  12. Benni Mack uploaded patch set 2 04/04/17, 07:48

  13. Frans Saris voted on patch set 2 CR +1 V +1 04/04/17, 07:50

  14. Oliver Hader commented on patch set 2 CR +1 V +1 04/04/17, 07:54

    Thx, works now with tmpl->linkData
  15. Benni Mack commented on patch set 2 CR 0 04/04/17, 07:56

    waiting for travis
  16. TYPO3com voted on patch set 2 V +1 04/04/17, 07:56 Completed build in 08m 27s on Tue, 4 Apr, 09:56 AM Test Summary: 56582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10276

  17. Mona Muzaffar voted on patch set 2 V +1 04/04/17, 08:01

  18. Benni Mack voted on patch set 2 CR +2 V +2 04/04/17, 08:01

  19. Gerrit merged patch set 2 04/04/17, 08:01