Review main Merged

52397[BUGFIX] Use correct order of SQL parameters in SysRefindexHashUpdater

Morton Jonuschat CR +2 V +2 Easy +3 −3 updated 04/14/17, 07:59

Commit message

Supply the positional parameter arguments to the update statement in 
the correct order. The statement used for the updates reads
'UPDATE `sys_refindex` SET `hash` = ? WHERE `hash` = ?'
and thus the parameters should be in the order new hash, old hash, 
not the other way around.
It's the final order in the statement that's relevant when supplying the 
parameters, not the order in which they are defined in PHP.

Changed the definition order in PHP to match the order in the final 
SQL statement as well.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1