Review main Abandoned

52404[WIP][FEATURE] Provide a class to cleanly build a URL

Elmar Hinz CR 0 V 0 Hard +827 −0 updated 11/30/17, 15:32

Commit message

Provide a class that cleanly builds a URL and that can
be used throught all parts of typolink and the TypolinkBuilder
Framework.

It already works as proof of concept. Try it out. Discuss it.

Should it be fully documented and implemented into typolink?

Review

  • Code review CR 0
  • Verified V 0

Files 4

Review log 1628

Show 23 earlier messages
  1. Elmar Hinz uploaded patch set 1 04/09/17, 13:47

  2. TYPO3com voted on patch set 1 V -1 04/09/17, 13:53 Completed build in 06m 25s on Sun, 9 Apr, 03:53 PM Test Summary: 56666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10413

  3. Elmar Hinz uploaded patch set 2 04/09/17, 16:14

  1. TYPO3com voted on patch set 2 V +1 04/09/17, 16:28 Completed build in 13m 49s on Sun, 9 Apr, 06:28 PM Test Summary: 56690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10414

  2. Elmar Hinz uploaded patch set 3 04/09/17, 16:41

  3. TYPO3com voted on patch set 3 V -1 04/09/17, 16:49 Completed build in 07m 58s on Sun, 9 Apr, 06:49 PM Test Summary: 56696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10415

  4. Elmar Hinz uploaded patch set 4 04/09/17, 17:45

  5. TYPO3com voted on patch set 4 V +1 04/09/17, 17:52 Completed build in 06m 31s on Sun, 9 Apr, 07:52 PM Test Summary: 56726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10416

  6. Elmar Hinz uploaded patch set 5 04/09/17, 18:14

  7. TYPO3com voted on patch set 5 V +1 04/09/17, 18:23 Completed build in 09m 17s on Sun, 9 Apr, 08:23 PM Test Summary: 56726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10417

  8. Elmar Hinz uploaded patch set 6 04/09/17, 18:57

  9. Oliver Klee commented on patch set 6 04/09/17, 19:00

    an -> a (because it is pronounced "You are Al.")
  10. TYPO3com voted on patch set 6 V +1 04/09/17, 19:05 Completed build in 07m 03s on Sun, 9 Apr, 09:05 PM Test Summary: 56726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10418

  11. Elmar Hinz uploaded patch set 7 04/09/17, 19:45

  12. TYPO3com voted on patch set 7 V +1 04/09/17, 19:53 Completed build in 07m 16s on Sun, 9 Apr, 09:53 PM Test Summary: 56732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10419

  13. Elmar Hinz uploaded patch set 8 04/09/17, 20:48

  14. TYPO3com voted on patch set 8 V -1 04/09/17, 20:55 Completed build in 06m 43s on Sun, 9 Apr, 10:55 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10420

  15. Elmar Hinz uploaded patch set 9 04/09/17, 20:56

  16. Elmar Hinz uploaded patch set 10 04/09/17, 20:57

  17. TYPO3com voted on patch set 9 V -1 04/09/17, 21:05 Completed build in 09m 07s on Sun, 9 Apr, 11:05 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10421

  18. TYPO3com voted on patch set 10 V +1 04/09/17, 21:07 Completed build in 10m 20s on Sun, 9 Apr, 11:07 PM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10422

  19. Elmar Hinz uploaded patch set 11 04/10/17, 00:50

  20. TYPO3com voted on patch set 11 V -1 04/10/17, 01:00 Completed build in 10m 07s on Mon, 10 Apr, 03:00 AM Test Summary: 6 of 56771 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10423

  21. Elmar Hinz uploaded patch set 12 04/10/17, 01:07

  22. TYPO3com voted on patch set 12 V +1 04/10/17, 01:14 Completed build in 06m 20s on Mon, 10 Apr, 03:14 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10424

  23. Benni Mack commented on patch set 12 CR -1 04/26/17, 18:14

    First, this is a actually not a class to build a Url, but to represent a Uri and the query string parts of that. Second, the TYPO3 Backend uses the standardized PSR-7 UriInterface with an implementation in EXT:core already for this, which could be utilized for building Urls. Far more interesting is the point on how to build such a Url, which could be done within the TypolinkBuilder classes now to return these objects, although I don't see the huge benefit of doing that right now.
  24. Elmar Hinz commented on patch set 12 04/27/17, 10:01

    Yes, this object only handle the clean formatting of the URL. Before getting on the composition of the URL I want to separate routing form the template service. To reasonable separate it, I first need to improve the mount points and root line stuff. So this dependencies define the order of my current road map.
  25. Benni Mack abandoned the change 11/30/17, 15:32

    abandoned. we should to stick to PSR-7 URI interface