Review main Merged

52445[BUGFIX] AbstractMessage should have string, but integer is given

Oliver Hader CR +2 V +2 Easy +5 −1 updated 04/14/17, 17:03

Commit message

FlashMessage setter have been extended with strict scalar types,
however the disposal for e.g. Exception has not been adjusted to
ensure proper types.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 04/14/17, 10:56

  2. Wouter Wolters voted on patch set 1 CR +1 04/14/17, 11:04

  3. TYPO3com voted on patch set 1 V +1 04/14/17, 11:08 Completed build in 11m 36s on Fri, 14 Apr, 01:08 PM Test Summary: 56666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10541

  4. Tymoteusz Motylewski commented on patch set 1 CR +1 V +1 04/14/17, 15:05

    easy to reproduce - just go offline and go to extension manager -> get preconfigured packages
  5. Wouter Wolters voted on patch set 1 CR +2 V +2 04/14/17, 17:03

  6. Gerrit merged patch set 1 04/14/17, 17:03