Review TYPO3_8-7 Merged

52635[BUGFIX] Remove wrong usage of PageRepository->error_getRootLine_failPid

Georg Ringer CR +2 V +2 Easy +10 −37 updated 04/27/17, 12:55

Commit message

The TypoScript frontend calls TSFE->sys_page->getRootline() which fills
the public property "error_getRootLine_failPid" when the third parameter
is set. Otherwise it throws an exception.

Setting this option was actually removed in TYPO3 when the RootlineUtility
was introduced, making the third parameter very non-useful, as it does not
throw exceptions but instead writing some weird values in the error_getRootLine
property.

It also goes back to the case where branch versioning was still supported.

In case of regular frontend requests there is a lot of dead code now because
of always-false checks on $TSFE->sys_page->error_getRootLine_failPid == -1.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1