Review main Abandoned Breaking

52740[!!!][FEATURE] Make page overlay methods independent from repository state

Elmar Hinz CR 0 V 0 Hard +609 −268 updated 03/19/18, 20:21

Commit message

- Add $versioningPreview and $versioningWorkspaceId as optional parameters
  to PageRecord::versionOL().

- Add $versioningPreview and $versioningWorkspaceId as optional parameters
  to PageRecord::fixVersioningPid().

- Add $versioningPreview and $versioningWorkspaceId as optional parameters
  to PageRecord::getPageOverlay().

- Review the methods used by this methods to support the feature.

- As a new feature return the resulting records of the methods. Hitherto they
  are dealt with by reference. Method references are not supported by PHPUnit.
  This feature makes mocking of the methods more easy in unit tests.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2