Review main Merged

52799[TASK] Use LanguageService inside TSFE

Benni Mack CR +2 V +2 Normal +106 −91 updated 10/16/17, 18:48

Commit message

TSFE does the same logic as $GLOBALS['LANG'] (= LanguageService) for
fetching labels and language files, but with a different language key.

However, LanguageService is not a singleton, so it _can_ be used
multiple times at the same request, so why not use the LanguageService
for labels based on config.sys_language, and the $GLOBALS['LANG'] record
based on the current backend user.

So, TSFE only acts as a wrapper for LanguageService instead of having
duplicate code.

A few now useless internal properties are dropped, some other
methods are deprecated:

- TSFE->LL_files_cache
- TSFE->LL_labels_cache

- TSFE->readLLfile()
- TSFE->getLLL()
- TSFE->initLLvars()

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5