52800[BUGFIX] Fix wrong comment in TSFE for xhtmlDoctype property
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Jochen Greiner uploaded patch set 1 05/13/17, 17:12
-
Harry Glatz voted on patch set 1 CR +1 V +1 05/13/17, 17:16
-
TYPO3com voted on patch set 1 V +1 05/13/17, 17:19 Completed build in 06m 28s on Sat, 13 May, 07:19 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11484
-
Elmar Hinz commented on patch set 1 CR -1 05/15/17, 05:35
Improve the title of the commit message. It names the bug. It should name the change. https://wiki.typo3.org/CommitMessage_Format_(Git)#Commit_Message_rules_for_TYPO3_CMS [BUGFIX] Short summary of changes introduced by this patch Most importantly, describe what is changed with the commit and not what is has not been working (that is part of the bug report already). -
Elmar Hinz voted on patch set 1 CR 0 05/15/17, 05:37
-
Wouter Wolters updated the commit message in patch set 2 05/18/17, 13:33
-
Wouter Wolters voted on patch set 2 CR +1 V +1 05/18/17, 13:33
-
TYPO3com voted on patch set 2 V +1 05/18/17, 13:40 Completed build in 06m 41s on Thu, 18 May, 03:40 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11573
-
Christian Kuhn voted on patch set 2 CR +2 V +2 05/18/17, 13:42
-
Gerrit merged patch set 2 05/18/17, 13:43
-
Christian Kuhn commented on patch set 3 05/18/17, 13:43
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b2195ac82b336da4fc7bf5253e460611bafd58ae