52801[BUGFIX] Add `controlsList` as known additional attribute
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Christian Kuhn +1
- Henrik Elsner +1
-
Verified V +2
- Jan Helke +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Resource/Rendering/AudioTagRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+37 −50
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+37 −50
Review log 1619
-
Andreas Kienast uploaded patch set 1 05/14/17, 09:12
-
TYPO3com voted on patch set 1 V +1 05/14/17, 09:18 Completed build in 05m 14s on Sun, 14 May, 11:18 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11485
-
Oliver Klee commented on patch set 1 05/14/17, 18:41
To me, this seems to be a FEATURE, not a BUGFIX. -
Oliver Klee commented on patch set 1 05/14/17, 18:41
And can we have tests for this? -
Jigal van Hemert voted on patch set 1 CR +1 05/14/17, 18:43
-
Jigal van Hemert commented on patch set 1 05/14/17, 18:45
> (1 comment) You could also look at it from another perspective: the bug is that a (new) parameter is missing :-) -
Andreas Kienast commented on patch set 1 05/15/17, 07:09
>And can we have tests for this? We'll see ;)Reply
Adding support for a simple HTML5 attribute does not qualify for a feature to me :) -
Andreas Kienast uploaded patch set 2 05/15/17, 07:30
-
TYPO3com voted on patch set 2 V +1 05/15/17, 07:36 Completed build in 05m 24s on Mon, 15 May, 09:36 AM Test Summary: 55862 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11494
-
Andreas Kienast uploaded patch set 3 05/15/17, 07:48
-
TYPO3com voted on patch set 3 V +1 05/15/17, 07:53 Completed build in 04m 59s on Mon, 15 May, 09:53 AM Test Summary: 55862 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11495
-
Henrik Elsner voted on patch set 3 CR +1 05/17/17, 10:39
-
Christian Kuhn voted on patch set 3 CR +1 V +1 05/17/17, 11:47
-
Jan Helke voted on patch set 3 CR +1 V +1 05/17/17, 11:54
-
Jan Helke voted on patch set 3 CR +2 V +2 05/17/17, 11:54
-
Gerrit merged patch set 3 05/17/17, 11:54
-
Jan Helke commented on patch set 4 05/17/17, 11:54
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 74340608226f4864c97ce42210e26a94c1d14a32 -
Stephan Großberndt commented on patch set 4 09/07/17, 07:55
Backport to 7.6 is missing -
Stephan Großberndt commented on patch set 4 12/21/17, 10:04
Backport to 7.6 is still missing