Review main Merged

52803[TASK] Deprecate "noWSOL" in PageRepository->getRecordRaw

Benni Mack CR +2 V +2 Normal +83 −8 updated 05/17/17, 12:16

Commit message

The method getRecordRaw has a very unspeakable method argument called
"noWSOL" which is only used internally within PageRepository.

Setting "noWSOL" to true only does a regular SQL query which can be implemented
directly in the according places, as the WSOL does not need to be known.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 05/14/17, 12:26

  2. TYPO3com voted on patch set 1 V +1 05/14/17, 12:34 Completed build in 08m 23s on Sun, 14 May, 02:34 PM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11487

  3. Georg Ringer voted on patch set 1 CR +1 V +1 05/15/17, 13:39

  4. Wouter Wolters voted on patch set 1 CR +1 05/17/17, 08:23

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 05/17/17, 12:16

  6. Gerrit merged patch set 1 05/17/17, 12:16