Review main Abandoned

52902[RESEARCH] Encapsulate PageRepository

Elmar Hinz CR 0 V 0 Normal +66 −14 updated 12/09/17, 02:12

Commit message

- 5 public properties are accessed from outsid
- 4 public propertes can be moved to protected

- 19 public methods are accessed from non-tests outsides
- 2 public methods are accessed from tests only
- 4 public mehtods can be moved to protected

- 2 public methods are not in use by the core at all

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 1221

  1. Elmar Hinz uploaded patch set 1 05/22/17, 14:05

  2. TYPO3com voted on patch set 1 V -1 05/22/17, 14:14 Completed build in 08m 58s on Mon, 22 May, 04:14 PM Test Summary: 1266 of 55890 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11684

  3. Elmar Hinz uploaded patch set 2 05/22/17, 14:17

  4. TYPO3com voted on patch set 2 V +1 05/22/17, 14:25 Completed build in 07m 46s on Mon, 22 May, 04:25 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11687

  5. Elmar Hinz uploaded patch set 3 05/22/17, 14:34

  6. TYPO3com voted on patch set 3 V -1 05/22/17, 14:43 Completed build in 08m 34s on Mon, 22 May, 04:43 PM Test Summary: 1394 of 55890 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11693

  7. Elmar Hinz uploaded patch set 4 05/22/17, 14:53

  8. TYPO3com voted on patch set 4 V -1 05/22/17, 15:35 Completed build in 41m 59s on Mon, 22 May, 05:35 PM Test Summary: 1596 of 55889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11699

  9. Elmar Hinz uploaded patch set 5 05/22/17, 15:42

  10. TYPO3com voted on patch set 5 V +1 05/22/17, 15:54 Completed build in 11m 56s on Mon, 22 May, 05:54 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11708

  11. Elmar Hinz uploaded patch set 6 05/22/17, 15:57

  12. TYPO3com voted on patch set 6 V +1 05/22/17, 16:07 Completed build in 09m 28s on Mon, 22 May, 06:07 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11713

  13. Elmar Hinz uploaded patch set 7 05/22/17, 16:10

  14. TYPO3com voted on patch set 7 V +1 05/22/17, 16:17 Completed build in 06m 56s on Mon, 22 May, 06:17 PM Test Summary: 55887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11718

  15. Elmar Hinz abandoned the change 05/30/17, 19:30

    DONE
  16. Elmar Hinz restored the change 06/01/17, 10:30

    Research methods.
  17. Elmar Hinz uploaded patch set 8 06/01/17, 11:16

  18. TYPO3com voted on patch set 8 V +1 06/01/17, 11:23 Completed build in 07m 02s on Thu, 1 Jun, 01:23 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11948

  19. Elmar Hinz updated the commit message in patch set 9 06/01/17, 11:41

  20. TYPO3com voted on patch set 9 V +1 06/01/17, 11:47 Completed build in 06m 26s on Thu, 1 Jun, 01:47 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11949

  21. Benni Mack abandoned the change 12/09/17, 02:12

    this has been fixed already (deprecated) and other methods are marked as deprecated already. thanks for the research, helped me!