Review TYPO3_8-7 Merged

52923[BUGFIX] Make encoding of parameters for cHash independent of PHP settings

Benni Mack CR +2 V +2 Easy +1 −1 updated 05/24/17, 09:58

Commit message

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
Our code relies on having a simple ampersand as this character.
If the PHP is set to a different configuration the code will fail.

This is fixed by enforcing the ampersand. Moreover we force RFC3986
encoding to ensure that decoding with rawurldecode() does the right
thing.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1