Review main Abandoned

52952[BUGFIX] Map date and datetime with named timezone instead of offset

Paul Golmann CR 0 V 0 Easy +12 −4 updated 03/18/25, 20:12

Commit message

Alignes the code for mapping timestamps with that of datetime database
fields. That means that the timezone will correctly be set as e.g.
Europe/Berlin instead of +02:00. This should prevent some issues
when working (modifying) the resulting \DateTime object regarding time
zones and daytime saving.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1520

  1. Paul Golmann uploaded patch set 1 05/29/17, 11:50

  2. Paul Golmann updated the commit message in patch set 2 05/29/17, 11:51

  3. TYPO3com voted on patch set 1 V -1 05/29/17, 11:58 Completed build in 07m 29s on Mon, 29 May, 01:58 PM Test Summary: 1 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11855

  4. TYPO3com voted on patch set 2 V -1 05/29/17, 12:15 Completed build in 23m 46s on Mon, 29 May, 02:15 PM Test Summary: 1 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11856

  5. Paul Golmann updated the commit message in patch set 3 05/29/17, 12:16

  6. TYPO3com voted on patch set 3 V +1 05/29/17, 12:22 Completed build in 06m 27s on Mon, 29 May, 02:22 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11858

  7. Paul Golmann uploaded patch set 4 05/29/17, 13:18

  8. TYPO3com voted on patch set 4 V +1 05/29/17, 13:25 Completed build in 07m 03s on Mon, 29 May, 03:25 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11861

  9. Andreas Allacher commented on patch set 4 05/29/17, 17:33

    DataMapper.php:339

    This bit is a bit confusing because one might think it is related to the next line in the code, whereas it actually is related to the one afterwards.
  10. Paul Golmann commented on patch set 4 05/30/17, 09:39

    DataMapper.php:339 Reply

    I agree. Should I move the highlighted text to the comment in line 341 or can someone come up with a better text? my english might not be the best :) feel free to change the RFC!
  11. Mathias Schreiber uploaded patch set 5 02/06/18, 19:43

  12. TYPO3com voted on patch set 5 V +1 02/06/18, 19:49 Completed build in 05m 43s on Tue, 6 Feb, 08:49 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19033

  13. Tobi Kretschmann voted on patch set 5 CR +1 03/05/18, 10:41

  14. Jörg Bösche voted on patch set 5 CR +1 03/06/18, 12:53

  15. Kay Strobach voted on patch set 5 CR -1 04/19/18, 08:22

  16. Kay Strobach commented on patch set 5 04/19/18, 08:23

    Thank you for your contribution please provide an rst file as this changes the behaviour, which is a breaking change!
  17. Björn Jacob commented on patch set 5 08/10/18, 21:17

    If this is a breaking change it cannot be backported to 8.7.
  18. Benni Mack abandoned the change 10/28/18, 16:10

    abandoned, as there was no activity in the last 6 months, please address these issues, this patch can then be restored once someone starts working on that one again.
  19. Benjamin Franzke restored the change 03/18/25, 20:11

  20. Benjamin Franzke abandoned the change 03/18/25, 20:12