Review main Abandoned

52975[RESEARCH] Encapsulate ContentObjectRenderer

Elmar Hinz CR 0 V 0 Easy +20 −9 updated 02/12/18, 17:30

Commit message

Check by experiment which public properties could be moved to internal.

- Don't break bamboo tests.
- Don't break FE or BE in smoke tests.

Results:

- 9 public properties are used by the core clases excluding tests
- 2 public properties are accessed from tests exclusively
- 9 public properties are not accessed at all

Conclusion:

11 of 20 public properties can easily be migrated to protected.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 59

  1. Elmar Hinz uploaded patch set 1 05/31/17, 08:46

  2. TYPO3com voted on patch set 1 V -1 05/31/17, 08:53 Completed build in 06m 34s on Wed, 31 May, 10:53 AM Test Summary: 1605 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11897

  3. Elmar Hinz uploaded patch set 2 05/31/17, 08:57

  4. TYPO3com voted on patch set 2 V -1 05/31/17, 09:04 Completed build in 06m 48s on Wed, 31 May, 11:04 AM Test Summary: 12 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11898

  5. Elmar Hinz uploaded patch set 3 05/31/17, 09:09

  6. TYPO3com voted on patch set 3 V +1 05/31/17, 09:16 Completed build in 07m 12s on Wed, 31 May, 11:16 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11899

  7. Elmar Hinz updated the commit message in patch set 4 05/31/17, 09:30

  8. TYPO3com voted on patch set 4 V +1 05/31/17, 09:37 Completed build in 07m 14s on Wed, 31 May, 11:37 AM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11900

  9. Frank Nägler abandoned the change 02/12/18, 17:30

    no activity since 9 month, I will abandon this patch for now. feel free to re-activate if anyone will work on it again.