Review main Abandoned

53056[BIGFIX] Show only visible be_groups in user edit mode

Markus Sommer CR 0 V 0 Easy +30 −11 updated 06/03/17, 11:48

Commit message

Test hidden field in be_user TCA `foreign_table_where`

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 913

  1. Markus Sommer uploaded patch set 1 06/02/17, 17:11

  2. Markus Sommer voted on patch set 1 CR -1 V -1 06/02/17, 17:17

  3. TYPO3com voted on patch set 1 V -1 06/02/17, 17:24 Completed build in 13m 10s on Fri, 2 Jun, 07:24 PM Test Summary: 1 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12122

  4. Markus Sommer uploaded patch set 2 06/02/17, 21:05

  5. Markus Sommer updated the commit message in patch set 3 06/02/17, 21:08

  6. Riccardo De Contardi voted on patch set 3 V +1 06/02/17, 21:08

  7. TYPO3com voted on patch set 2 V -1 06/02/17, 21:15 Completed build in 09m 46s on Fri, 2 Jun, 11:15 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12144

  8. TYPO3com voted on patch set 3 V -1 06/02/17, 21:17 Completed build in 09m 18s on Fri, 2 Jun, 11:17 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12145

  9. Markus Sommer uploaded patch set 4 06/02/17, 21:24

  10. TYPO3com voted on patch set 4 V +1 06/02/17, 21:32 Completed build in 07m 36s on Fri, 2 Jun, 11:32 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12150

  11. Christian Kuhn commented on patch set 4 CR -1 06/02/17, 21:40

    never hide hidden=1 records in backend. this is frontend only.
  12. Christian Kuhn commented on patch set 4 06/02/17, 21:47

    AbstractItemProvider.php:509

    -1 for adding additional info in this anonymous array key: give them names, could happen in single preparation patch.
  13. Christian Kuhn abandoned the change 06/03/17, 11:48

    will be solved differently.