Review main Merged Breaking

53109[!!!][FEATURE] Main install tool refactoring

Mona Muzaffar CR +2 V +2 Impossible +9583 −8178 updated 11/20/17, 08:17

Commit message

The patch applies a major refactoring of the "tool" part of the
install tool. As the most visible change, the install tool
application is now split from the "install" backend module menu
entry into four different entries - "Maintenance", "Settings",
"Upgrade" and "Environment". This is in-line with the strategy outline at
https://decisions.typo3.org/t/typo3-system-management-the-big-picture

The patch can be seen as the main separation and split patch to
introduce the integration of the install tool application
into the overall backend look and feel.

On the visible side, single install tool actions that were
spread over the old menu entries like "all configuration" and
friends are now given single "cards" within one of the four
main module entries. The "standalone" version of the install
tool is now similar to the backend view - just without all the
other module menu entries.

Aside from this major visible change, the patch comes with
a main refactoring of the underlying PHP code and click behavior:

* All "action" buttons that initiate something are now ajax based.
  Codewise, this is the major part.
* No main controller loads ext_tables / ext_localconf anymore.
* Main "Install.js" is now mostly a dispatcher to load specific
  requireJs components determined by given clicked main module.
* Major refactorinng of JavaScript output and click-flow.
* Introduce various new "services". Ajax actions always return
  objects and arrays, but no HTML. This is a major step towards
  proper cli and psr-7 integration.

Even with the install tool paradigm "never cache anything", the
application feels very snappy due to slim main controllers
and straight single Ajax action triggers.

Some parts of the internal PHP API of the install tool have been
changed. While the install tool is "internal" anyway, this patch
has been marked as [!!!] to hint extension developers in the
unlikely case it breaks some low level extension.

The state of this major change is not "perfect": There are
various details to improve. However, this patch has more than
9k lines, all major parts work fine and the huge file juggling
prevents other patches from being integrated. Glitches and
further improvements can be done with small patches afterwards.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 256

Show 236 more files