Review main Merged

53130[BUGFIX] Fix DB error handling in FrontendUserImageUpdateWizard

Morton Jonuschat CR +2 V +2 Easy +23 −22 updated 06/17/17, 16:15

Commit message

The errorCode() method returns a string representation of the error that happened.
Comparing this to an integer value to determine is not reliable. In addition Doctrine
throws Exceptions when database statements fail so this part of the code could not be
reached.
Catch the DBALException, extract the error message and let the re-raised extension
bubble up to show the actual error message to the user.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1