Review main Merged

53132[BUGFIX] Fix database query in StaticRecordCollection

Morton Jonuschat CR +2 V +2 Easy +8 −7 updated 07/14/17, 07:15

Commit message

Fix the query to fetch collection records to use an alias for the
foreign table instead of the MM tables and properly join on uid_local
and uid_foreign.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Morton Jonuschat uploaded patch set 1 06/06/17, 04:14

  2. TYPO3com voted on patch set 1 V +1 06/06/17, 04:21 Completed build in 07m 14s on Tue, 6 Jun, 06:21 AM Test Summary: 55386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12372

  3. Wouter Wolters voted on patch set 1 CR +1 07/03/17, 08:16

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 07/04/17, 20:16

  5. Tymoteusz Motylewski commented on patch set 1 CR -1 V -1 07/08/17, 17:42

    it improves the situation but does not solves it. Still an exception is thrown: An exception occurred while executing 'SELECT `pages`.* FROM `sys_col ... Unknown table 'pages'
  6. Tymoteusz Motylewski uploaded patch set 2 07/08/17, 17:44

  7. Tymoteusz Motylewski commented on patch set 2 07/08/17, 17:45

    fixed :)
  8. Tymoteusz Motylewski commented on patch set 2 07/08/17, 17:47

  9. TYPO3com voted on patch set 2 V +1 07/08/17, 17:55 Completed build in 10m 41s on Sat, 8 Jul, 07:55 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13053

  10. Wouter Wolters voted on patch set 2 CR +1 V +1 07/13/17, 18:40

  11. Tymoteusz Motylewski voted on patch set 2 CR +2 V +2 07/14/17, 07:14

  12. Gerrit merged patch set 2 07/14/17, 07:14

  13. Tymoteusz Motylewski commented on patch set 3 07/14/17, 07:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 81cdf006070eb2545dffc1d8af32dc9c904e710b