Review main Merged

53189[BUGFIX] Prefix single digit dates with 0 instead of whitespace

Sascha Egerer CR +2 V +2 Easy +3 −3 updated 06/12/17, 13:20

Commit message

The backend query view, used for csv exports and lists, uses a date
format where single digit days of a date value are prefixed with a
whitespace instead of a 0.
This ends up in useless CSV exports that can not be interpreted by
tools like Excel.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Manuel Selbach +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Sascha Egerer uploaded patch set 1 06/12/17, 11:08

  2. Sascha Egerer commented on patch set 1 CR -1 06/12/17, 11:13

    Will add tests (or adjust them if they are already there)
  3. TYPO3com voted on patch set 1 V +1 06/12/17, 11:19 Completed build in 10m 03s on Mon, 12 Jun, 01:19 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12520

  4. Sascha Egerer commented on patch set 1 CR 0 06/12/17, 11:25

    Ok no tests so far for thiss class. And this code is very complex to test. Do we need tests for this change?
  5. Manuel Selbach voted on patch set 1 CR +1 06/12/17, 12:37

  6. Benni Mack voted on patch set 1 CR +1 V +1 06/12/17, 12:45

  7. Benni Mack commented on patch set 1 06/12/17, 12:46

    Tests can be added, but probably in a bigger scope than this fix IMHO.
  8. Georg Ringer voted on patch set 1 CR +2 V +2 06/12/17, 13:02

  9. Gerrit merged patch set 1 06/12/17, 13:20

  10. Benni Mack commented on patch set 2 06/12/17, 13:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6e8ca1c3894826e5f0a38ca56d8fd5a22c85138f