53337[BUGFIX] Allow whitespaces in list of file extensions
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Brodala +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2024
-
Daniel Goerz uploaded patch set 1 06/27/17, 10:39
-
Daniel Goerz commented on patch set 1 06/27/17, 10:41
Note: This could potentialy lead to includes of files that have been ignored before. -
Mathias Brodala commented on patch set 1 CR -1 06/27/17, 10:44
GeneralUtility.php:2216This doesn't cover multiple spaces like GeneralUtility::trimExplode() does. -
TYPO3com voted on patch set 1 V +1 06/27/17, 10:49 Completed build in 09m 55s on Tue, 27 Jun, 12:49 PM Test Summary: 56739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12857
-
Mathias Brodala commented on patch set 1 CR 0 06/27/17, 10:51
GeneralUtility.php:2216ReplyActually it does. -
Daniel Goerz uploaded patch set 2 06/27/17, 10:51
-
Mathias Brodala voted on patch set 2 CR +1 V +1 06/27/17, 10:54
-
Daniel Goerz commented on patch set 2 06/27/17, 11:06
Not sure about 7.6 -
TYPO3com voted on patch set 2 V -1 06/27/17, 11:12 Completed build in 21m 29s on Tue, 27 Jun, 01:12 PM Test Summary: 1 of 57109 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12858
-
Daniel Goerz commented on patch set 2 06/27/17, 13:07
Bamboo -1 seems unrelated. Anyway, I will remove 7.6 for now as this patch has the tiny risk of changing TS inclusions. -
Daniel Goerz updated the commit message in patch set 3 06/27/17, 13:07
-
TYPO3com voted on patch set 3 V +1 06/27/17, 13:16 Completed build in 09m 33s on Tue, 27 Jun, 03:16 PM Test Summary: 56745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12859
-
Mathias Brodala voted on patch set 3 CR +1 V +1 06/27/17, 13:21
-
Stefan Froemken commented on patch set 3 06/28/17, 06:09
File extensions of what? I miss one sentence of explaination. Do you mean INCLUDE_TYPOSCRIPT -
Mathias Brodala updated the commit message in patch set 4 06/28/17, 07:01
-
Mathias Brodala voted on patch set 4 CR +1 V +1 06/28/17, 07:01
-
TYPO3com voted on patch set 4 V +1 06/28/17, 07:10 Completed build in 09m 46s on Wed, 28 Jun, 09:10 AM Test Summary: 56745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12861
-
Sascha Egerer commented on patch set 4 06/28/17, 07:46
Any reason not to use GeneralUtility::trimExplode and then array_search? -
Daniel Goerz commented on patch set 4 06/28/17, 08:18
> Any reason not to use GeneralUtility::trimExplode and then > array_search? What would be the benefit? -
Sascha Egerer commented on patch set 4 06/28/17, 08:25
> What would be the benefit? less fancy hard to understand string concatinations -
Mathias Brodala commented on patch set 4 06/28/17, 08:47
> > What would be the benefit? > > less fancy hard to understand string concatinations Just to be sure it's not forgotten if we go this route: in this case you absolutely need a strtolower() both on the extension of the file to check as well as the list of file extensions. -
Christian Kuhn voted on patch set 4 CR +2 V +2 06/29/17, 12:55
-
Gerrit merged patch set 4 06/29/17, 12:55
-
Christian Kuhn commented on patch set 5 06/29/17, 12:55
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9712a4239f48a964b8239ad438f21ede04134991