Review main Merged

53394[BUGFIX] EXT:indexed_search: Ensure that sword is a string

Daniel Goerz CR +2 V +2 Easy +3 −3 updated 07/12/17, 04:24

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Sascha Rademacher +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Daniel Goerz uploaded patch set 1 07/04/17, 11:25

  2. Daniel Goerz commented on patch set 1 07/04/17, 11:27

    Description on how to reproduce can be found in the issue.
  3. TYPO3com voted on patch set 1 V +1 07/04/17, 11:35 Completed build in 09m 52s on Tue, 4 Jul, 01:35 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12989

  4. Andreas Kienast commented on patch set 1 07/04/17, 11:43

    SearchController.php:1561

    (string)$sword as well?
  5. Daniel Goerz uploaded patch set 2 07/04/17, 11:54

  6. TYPO3com voted on patch set 2 V +1 07/04/17, 12:04 Completed build in 10m 38s on Tue, 4 Jul, 02:04 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12990

  7. Sascha Rademacher commented on patch set 2 CR +1 07/10/17, 08:35

    Looks good to me
  8. Jörg Bösche voted on patch set 2 CR +1 V +1 07/10/17, 09:17

  9. Georg Ringer commented on patch set 2 CR -1 07/11/17, 05:26

    SearchController.php:1568

    this is a breaking change. please don't force the return type
  10. Jörg Bösche uploaded patch set 3 07/11/17, 06:37

  11. TYPO3com voted on patch set 3 V +1 07/11/17, 06:48 Completed build in 10m 18s on Tue, 11 Jul, 08:48 AM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13075

  12. Sascha Rademacher voted on patch set 3 CR +1 07/11/17, 07:42

  13. Georg Ringer voted on patch set 3 CR +1 V +1 07/11/17, 07:56

  14. Benni Mack voted on patch set 3 CR +2 V +2 07/12/17, 04:23

  15. Gerrit merged patch set 3 07/12/17, 04:23

  16. Benni Mack commented on patch set 4 07/12/17, 04:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d609285d17cedeb599b0c6d4ab83a7d4d6a0814e