Review TYPO3_8-7 Merged

53419[BUGFIX] Make extensionName parameter optional for LocalizationUtility::translate()

Markus Klein CR +2 V +2 Easy +28 −2 updated 07/06/17, 14:26

Commit message

This patch prevents a PHP warning when second parameter of the method is not provided.
The extensionName is indeed optional since a fully qualified reference (starting with
"LLL:" may be provided as key.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Markus Klein commented on patch set 1 07/06/17, 13:26

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 07/06/17, 13:38 Completed build in 11m 50s on Thu, 6 Jul, 03:38 PM Test Summary: 58212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-523

  3. Markus Klein voted on patch set 1 CR +2 V +2 07/06/17, 14:26

  4. Gerrit merged patch set 1 07/06/17, 14:26