Review main Merged

53430[BUGFIX] Add video/x-m4v to supported mime types of VideoTagRenderer

Georg Ringer CR +2 V +2 Easy +1 −1 updated 07/13/17, 18:20

Commit message

Some videos might use the mime type video-x-m4v. To render those, the
mime type must be added to the list of supported mime types of the
renderer.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Maier +1
    • Frans Saris +1
    • Jörg Bösche +1
  • Verified V +2
    • Wouter Wolters +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Georg Ringer uploaded patch set 1 07/11/17, 05:33

  2. TYPO3com voted on patch set 1 V +1 07/11/17, 05:43 Completed build in 10m 10s on Tue, 11 Jul, 07:43 AM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13072

  3. Jörg Bösche commented on patch set 1 CR +1 V +1 07/11/17, 06:03

    Verified: Version dev-9 (master) and 8.7.3
  4. Tymoteusz Motylewski commented on patch set 1 07/11/17, 07:27

    hi Georg, any idea where to get a x-m4v file to test the patch?
  5. Jörg Bösche commented on patch set 1 07/11/17, 07:35

    > hi Georg, any idea where to get a x-m4v file to test the patch? You can use the m4v file of "Big Buck Bunny". Go to https://peach.blender.org/download/ and click on the link "IPod Touch / IPhone 640×360, 115 MB". This is a m4v file. Or search for "m4v sample download".
  6. Frans Saris voted on patch set 1 CR +1 07/11/17, 09:27

  7. Daniel Maier voted on patch set 1 CR +1 07/13/17, 10:23

  8. Wouter Wolters voted on patch set 1 CR +1 07/13/17, 11:17

  9. Wouter Wolters voted on patch set 1 CR +2 V +2 07/13/17, 18:20

  10. Gerrit merged patch set 1 07/13/17, 18:20

  11. Wouter Wolters commented on patch set 2 07/13/17, 18:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 012206f8281efe900185c7235da4dc542b697b7b